add docker file&improve the script - #3
Open
8-momo-8 wants to merge 1 commit into
Open
Conversation
Owner
|
I really don't think this needs a docker file, it's just a simple project I made over two years ago, the other files look alright |
varolbora5
reviewed
Nov 20, 2022
| 3)Run the program and wait | ||
| <ul><b><i>Run the program and wait </i></b></ul> | ||
|
|
||
| using_docker: |
| @@ -0,0 +1,12 @@ | |||
| FROM python:3.9.15-slim-bullseye | |||
Owner
There was a problem hiding this comment.
we can write about the required libraries in the readme
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I don't have API key to try but I added docker file and improved the script so you can use any name.mp4 and you don't need to edit the file to add the API key "not test , test before merge"