Fix: Rocket crash image not visible in light mode#131
Merged
vatsalsinghkv merged 1 commit intovatsalsinghkv:mainfrom Oct 28, 2025
sathwikhbhat:fix/rocket-crash-img
Merged
Fix: Rocket crash image not visible in light mode#131vatsalsinghkv merged 1 commit intovatsalsinghkv:mainfrom sathwikhbhat:fix/rocket-crash-img
vatsalsinghkv merged 1 commit intovatsalsinghkv:mainfrom
sathwikhbhat:fix/rocket-crash-img
Conversation
|
@sathwikhbhat is attempting to deploy a commit to the vatsalsinghkv's projects Team on Vercel. A member of the Team first needs to authorize it. |
Contributor
Author
|
@vatsalsinghkv, please review my PR when you are free... |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Owner
|
@sathwikhbhat Amazing work even I overlooked that. Thanks for contributing |
vatsalsinghkv
added
hacktoberfest
Contributor
Author
|
Happy to help @vatsalsinghkv |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The “rocket crash” image that appears when no search results are found was not visible in light mode, making the UI appear broken or incomplete.
Solution
Used the
useTheme()hook to render the apt image based on the active theme. Now there are two separate SVGs, one for dark mode and one for light mode, to ensure proper visibility across both themes. This ensures the image is clearly visible in both dark and light modes.Issue Resolved
Closes #130