Skip to content

Vatsim Brasil: TMA codes and airports corrections#1013

Merged
Adrian2k merged 7 commits intovatsimnetwork:masterfrom
vatsim-brasil:2507
Aug 5, 2025
Merged

Vatsim Brasil: TMA codes and airports corrections#1013
Adrian2k merged 7 commits intovatsimnetwork:masterfrom
vatsim-brasil:2507

Conversation

@fonfs
Copy link
Contributor

@fonfs fonfs commented Jul 7, 2025

Description of changes

Insert TMA codes (for proper display in VATSpy) and corrects some airports FIR's assignments.

Reason and motivation

TMA codes: to show correctly in VATSpy.
FIR reassignments: to work correctly with CCAMS.

Approved contributior?

  • I am on the approved contributers list
  • I have sent an request by email to get approved
  • Someone on the approved contributer list will review this request

Copy link
Collaborator

@daniluk4000 daniluk4000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

Something seems not right

@fonfs
Copy link
Contributor Author

fonfs commented Jul 11, 2025

@Adrian2k changes have been performed, by changing the last digit to 1.
@daniluk4000 my bad. Forgot to commit the boundaries. This is now done.

@Adrian2k Adrian2k requested a review from daniluk4000 July 11, 2025 19:40
@daniluk4000
Copy link
Collaborator

image

Copy link
Collaborator

@daniluk4000 daniluk4000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

SBRE/SBBS misaligment

image image

SBAZ

And more. .dat is good

@fonfs
Copy link
Contributor Author

fonfs commented Jul 14, 2025

Hello, @daniluk4000. I guess all holes have been removed. Thanks!

@Adrian2k
Copy link
Collaborator

A new contributer policy went in effect today - please read the new policy and reapply for contributer status.

@fonfs
Copy link
Contributor Author

fonfs commented Jul 18, 2025

A new contributer policy went in effect today - please read the new policy and reapply for contributer status.

Sent. 🆗

@Adrian2k
Copy link
Collaborator

Recieved and added to the approved list - thanks

@fonfs
Copy link
Contributor Author

fonfs commented Jul 31, 2025

@Adrian2k I ask for your consideration in reviewing this last commit. While not putting ALL airports in Brazil, the addition of public airports in Vatspy is very important for those who flies GA flights in Brazil, as most of them are performed in these smaller airports. It's hard to filter the data more extensively, hence why I ask for your consideration in approving the addition of these 346 public airports in Brazil.

Private ones shall be added in a case-by-case basis, according to the due relevance in the airspace. Helipads are out of the list.

@Adrian2k Adrian2k requested a review from daniluk4000 August 4, 2025 09:49
@Adrian2k
Copy link
Collaborator

Adrian2k commented Aug 4, 2025

We introduced new workflow files which we use to validate the files in all new pull-request - but we are unable to merge the new changes in master towards your branch, probably because the repository is on the vatsim-brazil organization.
image

Could you merge the recent changes in master into your 2507 branch, so we can run these new workflows?

Copy link
Collaborator

@daniluk4000 daniluk4000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Image

@Adrian2k Adrian2k merged commit 0a511bd into vatsimnetwork:master Aug 5, 2025
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants