Basic implementation of psql powered by postgres.js#106
Open
gitstart wants to merge 3 commits intovercel-labs:mainfrom
Open
Basic implementation of psql powered by postgres.js#106gitstart wants to merge 3 commits intovercel-labs:mainfrom
gitstart wants to merge 3 commits intovercel-labs:mainfrom
Conversation
|
@gitstart is attempting to deploy a commit to the Vercel Labs Team on Vercel. A member of the Team first needs to authorize it. |
![vercel[bot]](https://avatars.githubusercontent.com/in/8329?s=60&v=4){kind=small}
src/commands/psql/parser.ts
Outdated
| tuplesOnly: false, | ||
| quiet: false, | ||
| singleTransaction: false, | ||
| variables: {}, |
There was a problem hiding this comment.
Prototype pollution vulnerability in psql formatJson: object built from user-controlled column names uses {} instead of Object.create(null).
Author
There was a problem hiding this comment.
Fixed by using Object.create(null) instead of {} for the variables object. This prevents any prototype pollution attacks via the --set flag.
- Fix prototype pollution in parser: use Object.create(null) for variables - Fix -f flag: update getSqlToExecute to handle file input correctly - Add 25 unit tests covering all functionality
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
- Split tests into 4 files (availability, basic, formats, errors) - 44 tests with real PostgreSQL via postgres.js (no mocks) - Tests skip gracefully if PostgreSQL unavailable - Added PostgreSQL service to CI workflow - Added docker-compose for local testing - Follow repository patterns (env vs bash, multiple test files)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for implementing psql commands from agents. Key decisions include: