ci: run against node v18, 20 and 22 + run ultracite #152
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tobiasbueschel is attempting to deploy a commit to the Vercel Team on Vercel. A member of the Team first needs to authorize it. |
|
Good call. Thanks @tobiasbueschel 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As this package officially supports Node.js versions starting from v18, I thought it would be good to introduce the matrix strategy in the CI pipeline to ensure nothing breaks in other versions.
Likewise, I've added
pnpm checkto the pipeline so that we ensure static analysis & formatting runs successfully. On that note, when running it locally I've noticed many errors that I'd love to eventually fix. However, wanted to check here as to not duplicate any existing work or plan?It would be a lot of changes that I could add to this PR or a separate one for example?