feat(fireworks): add FireworksImageModelOptions type with providerOptions validation#12558
Open
saakshigupta2002 wants to merge 1 commit intovercel:mainfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a proper
FireworksImageModelOptionstype definition for Fireworks image model provider options, backed by a Zod schema and validated at runtime usingparseProviderOptions.This addresses the lack of type safety for Fireworks image generation provider options. Previously,
providerOptions.fireworkswas spread directly into the request body without any validation.Changes
packages/fireworks/src/fireworks-image-options.ts: Added Zod schema (fireworksImageModelOptions) defining all supported Fireworks image generation options (cfg_scale,steps,negative_prompt,strength,scheduler,safety_checker,output_format,safety_tolerance). Exported inferredFireworksImageModelOptionstype.packages/fireworks/src/fireworks-image-model.ts: IntegratedparseProviderOptionsto validate provider options against the Zod schema at runtime, replacing unvalidated...(providerOptions.fireworks ?? {})spread. Provider options are now consumed via individual property assignments.packages/fireworks/src/fireworks-image-model.test.ts: Updated tests to use schema-defined options instead of arbitrary pass-through properties.packages/fireworks/src/index.ts: ExportedFireworksImageModelOptionstype.examples/ai-functions/src/generate-image/fireworks.ts: Updated example to import and usesatisfies FireworksImageModelOptionsfor type-safe provider options.Verification
pnpm turbo build --filter=@ai-sdk/fireworks)pnpm turbo lint --filter=@ai-sdk/fireworks)Closes #12439