refactor(openai-compatible): deprecate normalized chat option shims#12594
Open
giulio-leone wants to merge 1 commit intovercel:mainfrom
Open
refactor(openai-compatible): deprecate normalized chat option shims#12594giulio-leone wants to merge 1 commit intovercel:mainfrom
giulio-leone wants to merge 1 commit intovercel:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
user)reasoningEffort,textVerbosity,strictJsonSchema)providerOptions.<providerName>Why
Issue #12461 highlights that OpenAI-compatible is an abstraction layer, so hard-coding provider-specific option names in the normalized model options is brittle. This change keeps compatibility while moving toward a cleaner contract.
Details
openaiCompatibleLanguageModelChatLegacyOptionsfor deprecated normalized option shims.openaiCompatibleLanguageModelChatOptionsfocused on stableuser.openai-compatible,openaiCompatible, and provider-name keysTests
pnpm --filter @ai-sdk/openai-compatible exec vitest --config vitest.node.config.js --run src/chat/openai-compatible-chat-language-model.test.tspnpm --filter @ai-sdk/openai-compatible exec eslint src/chat/openai-compatible-chat-options.ts src/chat/openai-compatible-chat-language-model.ts src/chat/openai-compatible-chat-language-model.test.tspnpm --filter @ai-sdk/openai-compatible type-checkpnpm exec prettier --check $(git diff --name-only)Closes #12461
Attribution request
If this pull request is merged, I would be grateful if contributor credit could be included in the related changelog or release notes for implementing this fix (@g97iulio1609).