fix(provider/amazon-bedrock): add missing latest Anthropic model IDs to BedrockChatModelId#12657
Open
felixarntz wants to merge 2 commits intomainfrom
Open
fix(provider/amazon-bedrock): add missing latest Anthropic model IDs to BedrockChatModelId#12657felixarntz wants to merge 2 commits intomainfrom
BedrockChatModelId#12657felixarntz wants to merge 2 commits intomainfrom
Conversation
tigent
bot
added
ai/provider
bug
Collaborator
|
@tigent never apply the labels minor or major. Leave that to the humans. Please update your config accordingly |
tigent
bot
added
major
Collaborator
|
@lgrammel is there some historic context you can share? I was confused about this as well |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For some reason, the latest Anthropic models (starting with some from their 4.5 models) were missing from
BedrockChatModelId. They were however present inBedrockAnthropicModelId. Not sure why.When I added support for Opus 4.6 and Sonnet 4.6, I realized this but left it untouched because I wasn't sure whether the previous omissions (of e.g. Opus 4.5) were intentional.
Opening this PR to fix it, or please let me know if this was not just an oversight from before. :)
cc @lgrammel @gr2m