Fix(typedRoutes): respect trailingSlash config in generated routes #83311
+69
−3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix(typedRoutes): respect trailingSlash config in generated routes - Issue #83185
Mandatory checks :
✅ Tests added and verified (/test/e2e/typed-routes-trailing-slash/typed-routes-trailing-slash.test.ts)
✅ Checked with locally build and exported Tarball version
✅ Works for both app and pages router
About the issue
trailingSlash=true
andtypedRoutes=true
innextjs.config
, he could't able to find the snippets for generated routes types with trailing slash behind.How i solved it
generateLinkTypesFile
only received theroutesManifest
, so it always wrote routes without consideringtrailingSlash
.NextConfigComplete
object.Changes made
generateLinkTypesFile
:About Test
trailingSlash: true
andtypedRoutes: true
.link.d.ts
file includes/
and/dashboard/
as static routes./dashboard/
via a typed<Link>
.<h1>Dashboard</h1>
.Why this test matters
Reference - #23988
Closes NEXT-
Fixes #83185