fix: Prevent pnpm overrides from corrupting resolved peer-dep variants#11844
Open
frankeld wants to merge 1 commit intovercel:mainfrom
Open
fix: Prevent pnpm overrides from corrupting resolved peer-dep variants#11844frankeld wants to merge 1 commit intovercel:mainfrom
frankeld wants to merge 1 commit intovercel:mainfrom
Conversation
Contributor
|
@frankeld is attempting to deploy a commit to the Vercel Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When a pnpm lockfile has overrides (e.g.
foo: ~1.0.0),turbo prunecan produce a broken lockfile that's missing snapshot entries for packages with multiple peer-dependency variants. This happens becauseapply_overridescorrupts already-resolved version strings like1.0.0(peer-a@1.0.0)(peer-b@2.0.0)by replacing them with the semver range from the override.This fix makes
resolve_specifierprefer the original specifier when it already matches a snapshot, so overrides only kick in when the specifier doesn't already resolve to a known package.These issues are reoccurring for many different users. See ongoing bug reports on this closed issue: #3382 (comment)
Here's a repository with a "real" minimal reproduction: https://github.com/frankeld/turbo-prune-repro
Testing Instructions
New unit tests in
crates/turborepo-lockfiles/src/pnpm/data.rs:This test sets up a v9 lockfile with an override (
foo: ~1.0.0) and two peer-dep variants offoo, then verifies that:resolve_packagestill resolves the transitive variant (foo@1.0.0(peer-a@1.0.0)(peer-b@2.0.0))