fix: use globalThis for step registry to survive module duplication#1373
Open
jcourson-bg wants to merge 2 commits intovercel:mainfrom
Open
fix: use globalThis for step registry to survive module duplication#1373jcourson-bg wants to merge 2 commits intovercel:mainfrom
jcourson-bg wants to merge 2 commits intovercel:mainfrom
Conversation
🦋 Changeset detectedLatest commit: 91bb717 The changes in this PR will be included in the next version bump. This PR includes changesets to release 16 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
@jcourson-bg is attempting to deploy a commit to the Vercel Labs Team on Vercel. A member of the Team first needs to authorize it. |
Author
|
Fixes #1374 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
registeredStepsonglobalThisviaSymbol.for()so all module instances share a single registry, matching the existing pattern inworld.tsProblem
In Turbopack dev mode,
private.jscan be instantiated as separate module instances across different chunk contexts.registerStepFunction(called from the generated step route) andgetStepFunction(called from the step handler) end up operating on differentMapinstances, causing "Step not found" errors.Test plan
pnpm buildpassespnpm testinpackages/core