Skip to content

[ci] fix: fix cpu_unit_test and tensordict CI on vllm_omni test, preparing for CI refactor#6205

Open
ETOgaosion wants to merge 4 commits intoverl-project:mainfrom
ETOgaosion:debug_ci
Open

[ci] fix: fix cpu_unit_test and tensordict CI on vllm_omni test, preparing for CI refactor#6205
ETOgaosion wants to merge 4 commits intoverl-project:mainfrom
ETOgaosion:debug_ci

Conversation

@ETOgaosion
Copy link
Copy Markdown
Collaborator

What does this PR do?

fix cpu_unit_test and tensordict CI on vllm_omni test, preparing for CI refactor

Checklist Before Starting

  • Search for similar PRs. Paste at least one query link here: ...
  • Format the PR title as [{modules}] {type}: {description} (This will be checked by the CI)
    • {modules} include fsdp, megatron, veomni, sglang, vllm, rollout, trainer, ci, training_utils, recipe, hardware, deployment, ray, worker, single_controller, misc, perf, model, algo, env, tool, ckpt, doc, data, cfg, reward, fully_async, one_step_off
    • If this PR involves multiple modules, separate them with , like [megatron, fsdp, doc]
    • {type} is in feat, fix, refactor, chore, test
    • If this PR breaks any API (CLI arguments, config, function signature, etc.), add [BREAKING] to the beginning of the title.
    • Example: [BREAKING][fsdp, megatron] feat: dynamic batching

Test

For changes that can not be tested by CI (e.g., algorithm implementation, new model support), validate by experiment(s) and show results like training curve plots, evaluation results, etc.

API and Usage Example

Demonstrate how the API changes if any, and provide usage example(s) if possible.

# Add code snippet or script demonstrating how to use this

Design & Code Changes

Demonstrate the high-level design if this PR is complex, and list the specific changes.

Checklist Before Submitting

Important

Please check all the following items before requesting a review, otherwise the reviewer might deprioritize this PR for review.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request enhances the handling of jagged NestedTensors by implementing custom utilities to bypass known PyTorch bugs in unbind and to_padded_tensor, specifically for 3D+ tensors and scenarios involving empty rows. It introduces _unbind_jagged_nested_tensor and _get_nested_tensor_ragged_idx to manage tensor splitting via values and offsets, and updates the multiturn_sft_dataset to support text-only tokenizers. Review feedback highlights potential performance regressions due to synchronous GPU-to-CPU data transfers when calling .tolist() on indices and .item() on tensor offsets within the new utility functions.

Comment thread verl/utils/tensordict_utils.py Outdated
Comment thread verl/utils/tensordict_utils.py Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant