[worker] feat: QAT with FP8 (w8a8 & w8a16)#6229
Draft
HollowMan6 wants to merge 2 commits intoverl-project:mainfrom
Draft
[worker] feat: QAT with FP8 (w8a8 & w8a16)#6229HollowMan6 wants to merge 2 commits intoverl-project:mainfrom
HollowMan6 wants to merge 2 commits intoverl-project:mainfrom
Conversation
Signed-off-by: Hollow Man <hollowman@opensuse.org>
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces FP8 Quantization-Aware Training (QAT) support for FSDP and Megatron backends, complementing the existing NVFP4 functionality. Key updates include the implementation of FP8 blockwise fake quantization kernels, the addition of w8a8 and w8a16 modes to the QATLinear module, and logic for exporting serialized FP8 weights and scales for vLLM rollout. The changes also incorporate configuration for 2D weight block sizes, ensure LoRA adapter weights remain unquantized, and provide compatibility updates for vLLM 0.19. Feedback highlights a redundant copy argument in a tensor conversion and a fragile string-based module path check in the Megatron patching logic.
Signed-off-by: Hollow Man <hollowman@opensuse.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Support w8a8 & w8a16 for QAT
Need NVIDIA-NeMo/Megatron-Bridge#3612
Checklist Before Starting
[{modules}] {type}: {description}(This will be checked by the CI){modules}includefsdp,megatron,veomni,sglang,vllm,rollout,trainer,ci,training_utils,recipe,hardware,deployment,ray,worker,single_controller,misc,perf,model,algo,env,tool,ckpt,doc,data,cfg,reward,fully_async,one_step_off,like[megatron, fsdp, doc]{type}is infeat,fix,refactor,chore,test[BREAKING]to the beginning of the title.[BREAKING][fsdp, megatron] feat: dynamic batchingTest
API and Usage Example
# Add code snippet or script demonstrating how to use thisDesign & Code Changes
Checklist Before Submitting
Important
Please check all the following items before requesting a review, otherwise the reviewer might deprioritize this PR for review.
pre-commit install && pre-commit run --all-files --show-diff-on-failure --color=alwaysci-requestchannel in theverlSlack workspace. (If not accessible, please try the Feishu group (飞书群).)recipesubmodule, please also update the reference to the submodule commit viagit submodule update --remoteorcd recipe && git pull origin main.