fix: make enable_meta_sniffer behavior consistent with CUSTOM_FALLBAC…#5006
Open
rz467fzs7d wants to merge 1 commit intovernesong:devfrom
Open
fix: make enable_meta_sniffer behavior consistent with CUSTOM_FALLBAC…#5006rz467fzs7d wants to merge 1 commit intovernesong:devfrom
rz467fzs7d wants to merge 1 commit intovernesong:devfrom
Conversation
…K_FILTER CUSTOM_FALLBACK_FILTER and ENABLE_META_SNIFFER have the same frontend interaction: both use a checkbox to control whether to use YAML custom config. However, their default behaviors are inconsistent when unchecked: - CUSTOM_FALLBACK_FILTER=0: respects YAML config - ENABLE_META_SNIFFER=0: forces sniffer to be disabled This fix makes them consistent: when unchecked, always respect the YAML config file settings. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
rz467fzs7d
force-pushed
the
fix/preserve-sniffer-config-dev
branch
from
8baa7cf to
bb3bf92
Compare
Contributor
Author
|
也可以遵循 SNIFFER 的控制逻辑，独立一个 ENABLE_FALLBACK_FILTER 来控制，逻辑上更清晰 ； 你们的想法呢？ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix: unify behavior when custom config options are unchecked
CUSTOM_FALLBACK_FILTER and ENABLE_META_SNIFFER have the same frontend interaction:
both use a checkbox to control whether to use YAML custom config.
However, their default behaviors are inconsistent when unchecked:
This fix makes them consistent: when unchecked, always respect the YAML config file settings.