Open
Conversation
mkovaxx
force-pushed
the
multiple-named-return-vals
branch
from
11d27fa to
2378916
Compare
parno
approved these changes
Mar 17, 2026
Collaborator
parno
left a comment
parno
left a comment
There was a problem hiding this comment.
This generally looks reasonable to me, and it's great to see how this already improves the legibility of some of the existing tests. However, I don't know this code super well, so it'd be good to get @Chris-Hawblitzel's input as well.
mkovaxx
commented
Mar 18, 2026
| parse_quote_spanned!(expr_span => { let #final_ret_pat = #ret_pat; #inner }); | ||
| *expr = wrap_expr_with_attrs(wrapped, attrs); | ||
| } | ||
| let ret_val_ident: Ident = Ident::new("_VERUS_ret_ident", Span::call_site()); |
Collaborator
Author
There was a problem hiding this comment.
@Chris-Hawblitzel Unconditionally introducing this "internal" identifier allows completely removing identifier collision checks (e.g. against the function's name).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ensuresto support complex patterns for binding the return value.By submitting this pull request, I confirm that my contribution is made under the terms of the MIT license.