This "fixes" the issue with vertically staggered keyboards jumping to "random" keys.#124
Open
BrianCArnold wants to merge 1 commit intovial-kb:mainfrom
Open
This "fixes" the issue with vertically staggered keyboards jumping to "random" keys.#124BrianCArnold wants to merge 1 commit intovial-kb:mainfrom
BrianCArnold wants to merge 1 commit intovial-kb:mainfrom
Conversation
…line of code is there for a *reason*. This is more of a proof-of-concept that this line is what's causing the keys being sorted in a non-sane way on v-staggered keyboards.
|
duplicate to #236 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This technically fixes the bug associated with #123, but obviously that line of code is there for a reason. This is more of a proof-of-concept that this line is what's causing the keys being sorted in a non-sane way on v-staggered keyboards. Perhaps either a new boolean field in the qmk JSON called
UseJsonKeyOrder?If
UseJsonKeyOrder == null || UseJsonKeyOrder == false, then still sort the keys by Y, then X, ifUseJsonKeyOrder == true, then use whatever order is in the JSON keymap.This would allow the maintainer of the vial keymap for a keyboard to say "no, seriously, I have these in the right order, don't screw with things." without causing problems for keymaps that may be entered in a non-sane order.