Pyinstaller branch rebase and fbs removal

[dwlocks]

I rebased that branch onto head, updated python to 3.12, updated Qt5 to latest, and allowed all dependencies to update accordingly. Then i removed FBS and implemented the minimum I could see that was needed to run (on windows).

This involved adding a couple json to the Vial.spec, some code to load those files, and the minimum possible amount of refactoring. There's more code that could be simplified with FBS gone, but I didn't want to go too far before getting some input and maybe getting someone to test on linux. I haven't kept a full vm handy for a couple years now...

[jashort]

Anecdotally, this seems to work on Linux for me.
Fedora Linux 40, Python 3.12.2, and following instructions in README.md

The Vial window opens, I can change key mappings on the keyboard, unlock the keyboard and run the matrix tester, save/load the keyboard layout.

[dwlocks]

I am still having issues with vial recognizing my via-configured keyboard, so I haven't even been able to test beyond "software builds and runs".

[koallen]

I managed to build this on a Mac but seems like it keeps opening new windows for some reason.

[tuopppi]

I had the same problem of application endlessly spawning new instances. This seems to be fixed by adding call to multiprocessing.freeze_support() to main.py

[limexp]

This PR saved me a lot of time trying to build on Windows.

@dwlocks, could you implement changes suggested by @tuopppi in the previous comment to push this PR forward?

[dwlocks]

This PR saved me a lot of time trying to build on Windows.

@dwlocks, could you implement changes suggested by @tuopppi in the previous comment to push this PR forward?
Unfortunately, you're overestimating my role: I can't move the PR forward. Only the repository owners/developers can accept PRs. I have strong doubts if this project is still active, sadly.

[dwlocks]

I had the same problem of application endlessly spawning new instances. This seems to be fixed by adding call to multiprocessing.freeze_support() to main.py

Huh, I had no idea this package used multiprocessing, but there it is:

vial-gui/src/main/python/autorefresh/autorefresh_thread.py

Line 12 in 2213e7c

from multiprocessing import RLock

Would you mind sending a patch for where this goes?

[tuopppi]

diff --git a/src/main/python/main.py b/src/main/python/main.py
index 1012acf..bab32b7 100644
--- a/src/main/python/main.py
+++ b/src/main/python/main.py
@@ -12,6 +12,7 @@ import certifi
 from PyQt5 import QtWidgets, QtCore
 from PyQt5.QtCore import pyqtSignal
 from PyQt5.QtWidgets import QApplication
+from multiprocessing import freeze_support
 
 from main_window import MainWindow
 # http://timlehr.com/python-exception-hooks-with-qt-message-box/
@@ -107,6 +108,9 @@ class VialApplicationContext():
 
 
 if __name__ == '__main__':
+    # https://pyinstaller.org/en/stable/common-issues-and-pitfalls.html#multi-processing
+    freeze_support()
+
     if len(sys.argv) == 2 and sys.argv[1] == "--linux-recorder":
         from linux_keystroke_recorder import linux_keystroke_recorder

[wez]

This is what I needed to get vial running on my m1 mac:

diff --git a/requirements.txt b/requirements.txt
index faa0f9d..5c2bb54 100644
--- a/requirements.txt
+++ b/requirements.txt
@@ -8,9 +8,9 @@ packaging==24.0
 pefile==2023.2.7
 pyinstaller==6.5.0
 pyinstaller-hooks-contrib==2024.3
-PyQt5==5.15.7
-PyQt5-Qt5==5.15.2
-PyQt5-sip==12.13.0
+PyQt5==5.15.11
+PyQt5-Qt5==5.15.11
+PyQt5-sip==12.15.0
 pywin32==306; sys_platform == 'win32'
 pywin32-ctypes==0.2.2
 setuptools==69.2.0
diff --git a/src/main/python/main.py b/src/main/python/main.py
index 1012acf..bab32b7 100644
--- a/src/main/python/main.py
+++ b/src/main/python/main.py
@@ -12,6 +12,7 @@ import certifi
 from PyQt5 import QtWidgets, QtCore
 from PyQt5.QtCore import pyqtSignal
 from PyQt5.QtWidgets import QApplication
+from multiprocessing import freeze_support

 from main_window import MainWindow
 # http://timlehr.com/python-exception-hooks-with-qt-message-box/
@@ -107,6 +108,9 @@ class VialApplicationContext():


 if __name__ == '__main__':
+    # https://pyinstaller.org/en/stable/common-issues-and-pitfalls.html#multi-processing
+    freeze_support()
+
     if len(sys.argv) == 2 and sys.argv[1] == "--linux-recorder":
         from linux_keystroke_recorder import linux_keystroke_recorder

[thomasaarholt]

Suggested change

	--icon="../src/main/icons/Icon.ico"
	--icon="../src/main/icons/Icon.ico" \

Added a missing trailing slash, which is needed for the CLI to run.

[LukeDRussell]

Works for me on Windows 11 with Python 3.12. Thanks @dwlocks.

[edevil]

This seems like a good direction. Is there anything that remains to be done?

[yannickroger]

It runs on ubuntu 22.04 with a python 3.12 from PPA. I hope this gets merged soon 👍

[YourPsychiatrist]

Has there been any progress on this? I wanted to contribute a feature but gave up trying to build the project after a few hours. (Am on linux.) Really a bummer that vial is stuck on fbs and its questionable practices.

EDIT: i found the pyinstaller branch and that one built for me after i relaxed the pyinstaller dependency. I guess that's the one i'm working with then