Add Apple silicon build, fix issue leading to infinitely spawning vials on Apple silicon - #395
Open
charlie-hotel wants to merge 1 commit into
Open
Add Apple silicon build, fix issue leading to infinitely spawning vials on Apple silicon#395charlie-hotel wants to merge 1 commit into
charlie-hotel wants to merge 1 commit into
Conversation
…ls on apple silicon
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Vial has recently started throwing alerts on macOS about the end of support for intel binaries, so added an Apple silicon build making minimal changes to deal with deps that don't exist on AS.
Added a new CI job and left the intel build as is. Had to take a different approach with PyInstaller on Apple silicon because fbs has no arm64 support, so I didn't want to unilaterally make changes to all the other builds.
Minor edits to main.py to derive resource loading strategy, and fixed an issue in autorefresh_thread.py to use threading.RLock instead of multiprocessing.RLock (when built under python versions >= 3.8, this leads to infinite process spawns on at least macOS)