APP-7502: Update FragmentHistoryEntry for fragment versioning #622
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaellee1019
changed the title
ehhong
reviewed
Jan 24, 2025
proto/viam/app/v1/app.proto
Outdated
| Fragment old = 3 [(tagger.v1.tags) = "bson:\"old\" json:\"old\""]; | ||
| AuthenticatorInfo edited_by = 4 [(tagger.v1.tags) = "bson:\"edited_by\" json:\"edited_by\""]; | ||
| string revision = 5 [(tagger.v1.tags) = "bson:\"revision\" json:\"revision\""]; | ||
| google.protobuf.Struct config = 6 [(tagger.v1.tags) = "bson:\"fragment\" json:\"fragment\""]; |
There was a problem hiding this comment.
double checking, this field config will eventually replace old? also, should the bson tags be config as well?
There was a problem hiding this comment.
Oops my bad about the tags, will update. Yes I think old will be deprecated. It doesn't make sense to drive the fragment version history off of old if we are storing that version's config as well. Plus its confusing to have the entire fragment in the response.
We have a lot of tasks to complete to migrate completely off of old and then we can deprecate it everywhere.
jr22
approved these changes
Jan 24, 2025
michaellee1019
added
the
ready-for-protos
michaellee1019
added
ready-for-protos
michaellee1019
removed
the
ready-for-protos
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the current config of the fragment history entry to the
GetFragmentHistoryAPI. This is a simplified version of an old PR that I found: #578. As Emily P mentioned in that PR, trying to do all changes at once is going to cause a headache in app as well as SDKs. Lets deprecate and rename the existing fields later and get the main parts of the project done first.