RSDK-12603 - reload build proto definitions #759
+1,570
−287
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stuqdog
added
ready-for-protos
stuqdog
commented
Oct 10, 2025
|
|
||
| message StartReloadBuildRequest { | ||
| oneof cloud_build { | ||
| packages.v1.CreatePackageRequest package = 1; |
There was a problem hiding this comment.
This is a bit of a compromise. I don't love the idea of putting one Request type inside another one, but I wanted to make sure we always captured the same data as a CreatePackageRequest (since we are in fact embedding a CreatePackage call within the StartReloadBuild call), and I didn't want to change the type out from under the existing CreatePackageRequest type because this would be breaking, slow things down by requiring a return to the scope process, and I don't have a good sense of the scope of its impact.
Happy to revisit if others disagree.
stuqdog
requested review from
a team,
lia-viam,
michaellee1019 and
njooma
and removed request for
a team
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.