Skip to content

feat: 更新部分代码#55

Closed
767829413 wants to merge 1 commit intovietnh1009:masterfrom
767829413:master
Closed

feat: 更新部分代码#55
767829413 wants to merge 1 commit intovietnh1009:masterfrom
767829413:master

Conversation

@767829413
Copy link
Copy Markdown

No description provided.

@HChaZZY
Copy link
Copy Markdown

HChaZZY commented Nov 20, 2024

Please use English, as @cdc12345 has said.
Meanwhile, please consider removing your output file data/output.txt or add them to .gitignore to maintain a clean repo.

Comment thread data/output.txt Outdated
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think if you could add output.txt into .gitignore file would do better for the container to hold this repo, maybe?

Comment thread .flake8 Outdated
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why should these two rules be added? For a green hand, I don't understand.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think he just wanted to push this commit to his own repo but didn't know how. xD

Copy link
Copy Markdown

@H-Sofie H-Sofie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This commit is meaningless, as it only modifies code formatting standards without making a significant contribution to readability.

@kongzyu
Copy link
Copy Markdown

kongzyu commented Nov 20, 2024

I think he wants to pull his repository, but wrong.

@MRSlouzk
Copy link
Copy Markdown

format some file and commit?hmmm...

Signed-off-by: Fang Yuan <wojiushifangyuanlove@gmail.com>
@767829413
Copy link
Copy Markdown
Author

767829413 commented Nov 21, 2024

I'm running

python3 -u img2txt.py --input /home/tmp/pexels-pixabay-163016.jpg --output /home/tmp/pexels-pixabay-163016.txt 

and I'm getting an error:

code/python/ASCII- generator/img2txt.py:25: SyntaxWarning: invalid escape sequence ‘\|’
  CHAR_LIST = ‘$@B%8&WM#*oahkbdpqwmZO0QLCJUYXzcvunxrjft/\|()1{}[]? -_+~<>i!lI;:,\‘^`’. ’, 

my pythion version is

python3 -V
Python 3.12.3

so in order to solve this problem, I modified the way to write CHAR_LIST, and used Flake8 as my Python code checker, sorry for initiating an inappropriate PR, the reason why I used the Chinese commit is because I didn't see the relevant contribution requirements, here I made the change

@H-Sofie
Copy link
Copy Markdown

H-Sofie commented Nov 21, 2024

Plz refer to #52

Comment thread utils.py
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes seem meaningless.

@767829413 767829413 closed this Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants