-
Notifications
You must be signed in to change notification settings - Fork 10
Implement (de)serialization for Box, Arc, and Rc, and serialization for references #48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
progval
wants to merge
1
commit into
vigna:main
Choose a base branch
from
progval:impl-box
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…or references We can't implement deserialization for references because something has to own them. Unfortunately, we can't have a blanket impl for `Deref`: ``` error[E0119]: conflicting implementations of trait `traits::copy_type::CopyType` for type `[_; _]` --> epserde/src/impls/deref.rs:19:1 | 19 | impl<T: Deref<Target: CopyType>> CopyType for T { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ conflicting implementation for `[_; _]` | ::: epserde/src/impls/array.rs:19:1 | 19 | impl<T: CopyType, const N: usize> CopyType for [T; N] { | ----------------------------------------------------- first implementation here | = note: upstream crates may add a new impl of trait `std::ops::Deref` for type `[_; _]` in future versions ``` and also not for `Borrow<_>`: ``` error[E0119]: conflicting implementations of trait `traits::copy_type::CopyType` for type `[_; _]` --> epserde/src/impls/deref.rs:19:1 | 19 | impl<Borrowed: CopyType, T: Borrow<Borrowed>> CopyType for T { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ conflicting implementation for `[_; _]` | ::: epserde/src/impls/array.rs:19:1 | 19 | impl<T: CopyType, const N: usize> CopyType for [T; N] { | ----------------------------------------------------- first implementation here error[E0207]: the type parameter `Borrowed` is not constrained by the impl trait, self type, or predicates --> epserde/src/impls/deref.rs:19:6 | 19 | impl<Borrowed: CopyType, T: Borrow<Borrowed>> CopyType for T { | ^^^^^^^^ unconstrained type parameter ```
This doesn't work as well as I'd like. For example, this code: use std::borrow::Borrow;
use std::marker::PhantomData;
use epserde::prelude::*;
use epserde::Epserde;
#[derive(Epserde)]
pub struct InnerStruct<T: AsRef<[u64]>> {
data: T,
}
#[derive(Epserde)]
pub struct OuterStruct<T: AsRef<[u64]>, BorrowInner: Borrow<InnerStruct<T>>> {
inner: BorrowInner,
marker: PhantomData<T>,
}
fn main() {
let original = OuterStruct {
inner: InnerStruct {
data: vec![1, 2, 3],
},
marker: PhantomData,
};
let mut file = std::io::Cursor::new(vec![]);
original.serialize(&mut file).expect("Could not serialize");
let data = file.into_inner();
let deserialized = <OuterStruct<Vec<u64>, InnerStruct<Vec<u64>>>>::deserialize_eps(&data)
.expect("Could not deserialize");
} Should make it possible to serialize
It's an improvement over what we got before this PR though:
but still not enough. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can't implement deserialization for references because something has to own them.
Unfortunately, we can't have a blanket impl for
Deref
:and also not for
Borrow<_>
: