Fixes to support installation on Apple Silicon (ARM) #20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for building and installing the SymSpellCppPy package on Apple Silicon (ARM) Macs by updating CMake requirements, adding ARM64-specific build configurations, and creating a comprehensive CI workflow for wheel building across multiple platforms.
- Updates CMake minimum version to 3.18.0 for Apple Silicon support and adds ARM64-specific compiler flags
- Modernizes Python version requirements (3.7+ instead of 3.4+) and pybind11 dependencies
- Introduces automated wheel building workflow with support for multiple platforms including Apple Silicon
Reviewed Changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| setup.py | Adds CMake version checks, Apple Silicon compiler flags, and updates Python/dependency requirements |
| CMakeLists.txt | Updates minimum CMake version and adds ARM64-specific build optimizations |
| .github/workflows/build-wheels.yml | New CI workflow for building wheels across platforms including Apple Silicon support |
Add better architecture support for Apple Silicon (and Linux in build.whl), Copilot recommendations Co-authored-by: Copilot <[email protected]>
|
I think that should be everything |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I pulled this onto an M1 Macbook Pro I noticed I was unable to install it, cmake would run into depedency issues that were intractable on the platform. I made a few changes in this which allowed me to successfully install it via
pip install .on my system. I added a wheel builder that I was able to then test installation viapip install git+https://github.com/skyler14/symspellcpppy.gitand successfully install in another conda environment. These aren't comprehensively tested but I think should cover many platforms.