Skip to content

Create a delay prior to sending UDP responses #283

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ddweber456 wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Create a delay prior to sending UDP responses #283

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1774b33
Update fauxmoESP.cpp
ddweber456 Oct 16, 2025
c5bc416
Update fauxmoESP.h
ddweber456 Oct 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
52 changes: 48 additions & 4 deletions src/fauxmoESP.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,10 +52,10 @@ void fauxmoESP::_sendUDPResponse() {
);

#if DEBUG_FAUXMO_VERBOSE_UDP
DEBUG_MSG_FAUXMO("[FAUXMO] UDP response sent to %s:%d\n%s", _udp.remoteIP().toString().c_str(), _udp.remotePort(), response);
DEBUG_MSG_FAUXMO("[FAUXMO] UDP response sent to %s:%d\n%s", _udpRequestIP.toString().c_str(), _updRequestPort, response);
#endif

_udp.beginPacket(_udp.remoteIP(), _udp.remotePort());
_udp.beginPacket(_udpRequestIP, _updRequestPort);
#if defined(ESP32)
_udp.printf(response);
#else
Expand All @@ -81,13 +81,57 @@ void fauxmoESP::_handleUDP() {
String request = (const char *) data;
if (request.indexOf("M-SEARCH") >= 0) {
if ((request.indexOf("ssdp:discover") > 0) || (request.indexOf("upnp:rootdevice") > 0) || (request.indexOf("device:basic:1") > 0)) {
_sendUDPResponse();
// Retrieve MX value from the packet

if (!_isDelayed) { // can only handle one queued MX response

randomSeed(millis());
int mxValue = 0;
int mxIndex = request.indexOf("MX:");
if (mxIndex >= 0) {
String mxString = request.substring(mxIndex + 4);
mxValue = mxString.toInt();
}

// Generate a random delay between 0 and MX seconds (convert to milliseconds)
_randomDelay = (mxValue > 0) ? random(0, mxValue * 1000) : random(0, 1000);
_delayStart = millis();
_isDelayed = true;

_udpRequestIP = _udp.remoteIP();
_updRequestPort = _udp.remotePort();
}

// Log the delay
#if DEBUG_FAUXMO_VERBOSE_UDP
DEBUG_MSG_FAUXMO("[FAUXMO] M-SEARCH received. Delaying response for %d ms.\n", _randomDelay);
#endif

// The actual _sendUDPResponse will be sent from _handleUDPDelay()
return;
// _sendUDPResponse();
}
}
}

}

// New method to handle the non-blocking delay
void fauxmoESP::_handleUDPDelay() {
if (_isDelayed) {
if ((millis() - _delayStart) >= _randomDelay) {
#if DEBUG_FAUXMO_VERBOSE_UDP
DEBUG_MSG_FAUXMO("[FAUXMO] Non-blocking delay finished. Sending UDP response.\n")
#endif

// Call the function that sends the UDP response
_sendUDPResponse();

// Reset the state
_isDelayed = false;
_randomDelay = 0;
}
}
}

// -----------------------------------------------------------------------------
// TCP
Expand Down
11 changes: 11 additions & 0 deletions src/fauxmoESP.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,6 +116,14 @@ class fauxmoESP {
AsyncServer * _server;
bool _enabled = false;
bool _internal = true;
// New additions for non-blocking delay based on MX value
unsigned long _delayStart = 0;
unsigned int _randomDelay = 0;
bool _isDelayed = false;

IPAddress _udpRequestIP;
uint16_t _updRequestPort;
//
unsigned int _tcp_port = FAUXMO_TCP_PORT;
std::vector<fauxmoesp_device_t> _devices;
#ifdef ESP8266
Expand All @@ -128,6 +136,9 @@ class fauxmoESP {

String _deviceJson(unsigned char id, bool all); // all = true means we are listing all devices so use full description template

// Helper method to handle the non-blocking delay
void _handleUDPDelay();

void _handleUDP();
void _onUDPData(const IPAddress remoteIP, unsigned int remotePort, void *data, size_t len);
void _sendUDPResponse();
Expand Down