Skip to content

Handle user-clicked-language event#167

Merged
mikhail-yevstratiev merged 5 commits into
trunkfrom
feature/handle-user-clicked-language-event
Aug 6, 2025
Merged

Handle user-clicked-language event#167
mikhail-yevstratiev merged 5 commits into
trunkfrom
feature/handle-user-clicked-language-event

Conversation

@mikhail-yevstratiev

Copy link
Copy Markdown
Contributor

🔗 Related Links

⬅️ As Is

Explain the current situation of the code

  • Changing language on web is not reflected in Virtusize widgets

➡️ To Be

  • Language in Virtusize widgets is changed after selecting language on web

☑️ Checklist

  • Useless comments and/or Log.d etc are removed
  • Unit test are covered
  • Code has been deployed and tested on STG
  • ClickUp ticket status has been updated to production
  • Update CHANGELOG.md with the new changes

@mikhail-yevstratiev mikhail-yevstratiev changed the title Feature/handle user clicked language event Handle user-clicked-language event Aug 5, 2025

@devAbhimanyu devAbhimanyu left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor refactor update naming

Comment thread virtusize-core/src/main/java/com/virtusize/android/data/local/VirtusizeEvent.kt Outdated
virtusizeRepository.updateUserSession()
}

is VirtusizeEvent.UserClickedLanguage -> {

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UserClickedLanguageSelector

/**
* @see Virtusize.setDisplayLanguage
*/
override fun setDisplayLanguage(language: VirtusizeLanguage) {

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

setVsWidgetLanguage

* Sets the display language for the Virtusize widgets
* @param language the display language set by a client
*/
internal suspend fun setDisplayLanguage(language: VirtusizeLanguage) =

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

setVsWidgetLanguage

Comment thread CHANGELOG.md Outdated
@@ -1,3 +1,6 @@
### Next release
- Feature: Add handling of language change on web in Virtusize widgets

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add event listener to handle of language change on web in Virtusize widgets

@devAbhimanyu devAbhimanyu left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 comment

Comment thread CHANGELOG.md Outdated
@@ -1,5 +1,5 @@
### Next release
- Feature: Add handling of language change on web in Virtusize widgets
- Feature: Add event listener to handle of language change on web in Virtusize widgets

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add event listener to handle language change on web in Virtusize widgets

@devAbhimanyu devAbhimanyu left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mikhail-yevstratiev mikhail-yevstratiev merged commit 13fc2fb into trunk Aug 6, 2025
3 checks passed
@mikhail-yevstratiev mikhail-yevstratiev deleted the feature/handle-user-clicked-language-event branch August 6, 2025 08:04
@mikhail-yevstratiev mikhail-yevstratiev mentioned this pull request Aug 6, 2025
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants