Skip to content

[NSDK-357] Hide component when product check returns invalid product state #176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ObranS merged 1 commit into from
Nov 17, 2025
Merged

[NSDK-357] Hide component when product check returns invalid product state #176

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion virtusize/src/main/java/com/virtusize/android/VirtusizeImpl.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -239,7 +239,7 @@ internal class VirtusizeImpl(
virtusizeViews
.filterIsInstance<VirtusizeInPageView>()
.forEach { virtusizeView ->
virtusizeView.showInPageError(externalProductId)
virtusizeView.showInPageError(externalProductId, error)
}
}

Expand Down
4 changes: 3 additions & 1 deletion virtusize/src/main/java/com/virtusize/android/ui/VirtusizeButton.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,9 @@ class VirtusizeButton
super.setProductWithProductCheckData(productWithPDC)
if (clientProduct!!.externalId == productWithPDC.externalId) {
clientProduct!!.productCheckData = productWithPDC.productCheckData
visibility = View.VISIBLE
if (clientProduct?.productCheckData?.data?.validProduct == true) {
visibility = View.VISIBLE
}
setupButtonTextConfiguredLocalization(virtusizeParams.language)
setOnClickListener {
openVirtusizeWebView(context, clientProduct!!)
Expand Down
13 changes: 12 additions & 1 deletion virtusize/src/main/java/com/virtusize/android/ui/VirtusizeInPageMini.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,8 @@ import coil.ImageLoader
import coil.decode.GifDecoder
import coil.request.ImageRequest
import com.virtusize.android.R
import com.virtusize.android.data.local.VirtusizeError
import com.virtusize.android.data.local.VirtusizeErrorType
import com.virtusize.android.data.local.VirtusizeLanguage
import com.virtusize.android.data.local.VirtusizeMessageHandler
import com.virtusize.android.data.local.VirtusizeParams
Expand Down Expand Up @@ -169,10 +171,19 @@ class VirtusizeInPageMini
/**
* @see VirtusizeInPageView.showInPageError
*/
override fun showInPageError(externalProductId: String?) {
override fun showInPageError(
externalProductId: String?,
error: VirtusizeError?,
) {
if (clientProduct!!.externalId != externalProductId) {
return
}

if (error?.type == VirtusizeErrorType.InvalidProduct) {
binding.root.visibility = View.GONE
return
}

binding.gifImageLayout.visibility = View.GONE
binding.inpageMiniLayout.visibility = View.VISIBLE
binding.inpageMiniLoadingText.visibility = View.GONE
Expand Down
11 changes: 10 additions & 1 deletion virtusize/src/main/java/com/virtusize/android/ui/VirtusizeInPageStandard.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@ import coil.decode.GifDecoder
import coil.request.ImageRequest
import com.virtusize.android.R
import com.virtusize.android.Virtusize
import com.virtusize.android.data.local.VirtusizeError
import com.virtusize.android.data.local.VirtusizeErrorType
import com.virtusize.android.data.local.VirtusizeLanguage
import com.virtusize.android.data.local.VirtusizeMessageHandler
Expand Down Expand Up @@ -324,11 +325,19 @@ class VirtusizeInPageStandard
/**
* @see VirtusizeInPageView.showInPageError
*/
override fun showInPageError(externalProductId: String?) {
override fun showInPageError(
externalProductId: String?,
error: VirtusizeError?,
) {
if (clientProduct!!.externalId != externalProductId) {
return
}

if (error?.type == VirtusizeErrorType.InvalidProduct) {
binding.root.visibility = View.GONE
return
}

binding.gifImageLayout.visibility = View.GONE
binding.inpageCardView.visibility = View.VISIBLE
binding.inpageFooter.visibility = View.VISIBLE
Expand Down
6 changes: 5 additions & 1 deletion virtusize/src/main/java/com/virtusize/android/ui/VirtusizeInPageView.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ package com.virtusize.android.ui
import android.content.Context
import android.util.AttributeSet
import android.widget.RelativeLayout
import com.virtusize.android.data.local.VirtusizeError
import com.virtusize.android.data.local.VirtusizeLanguage

/**
Expand Down Expand Up @@ -42,7 +43,10 @@ abstract class VirtusizeInPageView
/**
* An abstract function to show the InPage error screen with the associated external product ID
*/
internal abstract fun showInPageError(externalProductId: String?)
internal abstract fun showInPageError(
externalProductId: String?,
error: VirtusizeError?,
)

/**
* Sets the language for the view and updates all texts accordingly
Expand Down