Update wait-for-it.sh #130
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactor TCP host/port availability script - Enhanced variable naming for better readability - Simplified and improved argument parsing logic - Improved error handling, especially around timeout logic - Refactored functions for simplicity and maintainability - Consistently used `nc -z` for port checking - Enhanced signal handling for better script termination - Updated usage instructions for clarity These changes make the script more readable, maintainable, and robust.
syntaxsdev
approved these changes
Jul 9, 2024
|
@archit15singh looks good. |
|
@vishnubob LGTM? |
|
can we merge this please? |
|
@archit15singh The project has been abandoned — the last commit was 5 years ago. I recommend Wait4X instead. |
|
Oh alright. Thank you! |
|
Starred it ⭐ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor TCP host/port availability script
nc -zfor port checkingThese changes make the script more readable, maintainable, and robust.