fix: Change timeout invocation to support breaking change #83
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In busybox commit [c9720a761][], a breaking change was introduced that removes the `-t` flag to `timeout` in favor of just taking the time as the second arg, bringing it in line with coreutils' `timeout`. This commit was included in tag [1.31.1][], released on 25 Oct, 2019, at which point my integration tests that spin up a server using wait-for-it started to fail. [c9720a761]: mirror/busybox@c9720a7 [1.31.1]: https://github.com/mirror/busybox/releases/tag/1_31_1
|
My CI was also been failing for the same reason. This has resolved the issue. |
|
looks too early to drop support of Alpine immediately after new version release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In busybox commit c9720a761, a breaking change was introduced that
removes the
-tflag totimeoutin favor of just taking the time asthe second arg, bringing it in line with coreutils'
timeout. Thiscommit was included in tag 1.31.1, released on 25 Oct, 2019, at
which point my integration tests that spin up a server using wait-for-it
started to fail.
Fixes #82 .