io: use fios2 #90
Draft
io: use fios2 #90
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isage
reviewed
Aug 21, 2022
| #define SCE_FIOS_OPATTR_INITIALIZER { 0, 0, 0, 0, 0, 0, 0, 0 } | ||
| #define SCE_FIOS_RAM_CACHE_CONTEXT_INITIALIZER { sizeof(SceFiosRamCacheContext), 0, (64 * 1024), NULL, NULL, 0, {0, 0, 0} } | ||
|
|
||
| typedef enum SceFiosWhence { |
d3m3vilurr
reviewed
Aug 29, 2022
Comment on lines
+74
to
+82
| typedef struct SceFiosRamCacheContext { | ||
| size_t sizeOfContext; | ||
| size_t workBufferSize; | ||
| size_t blockSize; | ||
| void *pWorkBuffer; | ||
| const char *pPath; | ||
| intptr_t flags; | ||
| intptr_t reserved[3]; | ||
| } SceFiosRamCacheContext; |
There was a problem hiding this comment.
can we use snake_case instead of camelCase?
eg;
pPtr->ptrpCallback->callbackpCallbackContext->callback_contextuserTag->user_tagor justtaguserPtr->user_ptror justuserpReserved->reservedsizeOfContext->size_of_contextworkBufferSize->work_buffer_size,work_buf_sizeorbuf_sizeblockSize->block_sizepWorkBuffer->work_buffer,bufferor justbuf- ...
There was a problem hiding this comment.
no problem. I'm still reversing some of the stuff and these are leftovers from vitashell.
There was a problem hiding this comment.
@TheOfficialFloW can you allow changing the license to LGPL or others?
|
@frangarcj you might want to take a look at #92 because i'm pretty sure fios rename behaves the same |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Missing: