Prevent space key from scrolling the page in Graph view #47
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We have set up buttons and shortcut keys for zoom on the page, and browsers also have shortcut keys for zoom in/out web windows. Therefore, I prefer to respect to the browser's default behavior here, as I think it will be more intuitive for most users. |
|
Agreed. Respecting browser defaults may be better. |
|
Thank you for your contribution, let's close it to respect the default browser behavior. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, I often use Figma and am used to holding the space key to zoom. On this page, holding space scrolls the whole window, which feels a bit off. This PR prevents the space key from scrolling the page in the Graph view.
Is everyone okay with this change, or does anyone prefer the original behavior?
7.18.1.mov