You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I think instead of adding ?no-inline automatically, we need to tell @vue/compiler-sfc not to strip the queries and hashes (not sure if @vue/compiler-sfc is doing that). Otherwise, <img src="./foo.svg?inline"> or <img src="./foo.png?no-inline"> won't work as users expect.
I haven't been able to find the relevant configuration.
Currently, it will only add ?no-inline to the href attribute of the use tag(it seems that only the use tag cannot directly load the data URIs link), which should not affect the processing of the img tag.
I haven't been able to find a better way, and would appreciate your suggestions.
Adding ?no-inline automatically for <use> in plugin-vue makes sense to me.
That said, if there isn't an option in @vue/compiler-sfc, I think that needs to be added to support other cases.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
fix #490
Additional context
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123).