Skip to content

fix(build): replace names in the manifest with unmangled name for CSS assets #20585

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix(build): replace names in the manifest with unmangled name for CSS assets #20585

wants to merge 2 commits into from
+23 −12

Conversation

CyberAP
Copy link
Contributor

@CyberAP CyberAP commented Aug 10, 2025

Description

This PR removes the names field from the manifest for CSS entrypoints which had incorrect CSS entrypoint names. Instead, a name field is added that uses CSS entrypoint name as-is.

Additional context: #19912 (comment)

fix(build): replace 'names' with unmangled 'name' for CSS assets
741611a 
This removes the 'names' field which had incorrect CSS entrypoint names.
Instead, a 'name' field is added that uses CSS entrypoint name as-is.
@CyberAP
Copy link
Contributor Author

CyberAP commented Aug 10, 2025

@sapphi-red hi! Based on this discussion I think names should just be removed because it seems like it's different from what Rollup does with names for OutputAssets. I managed to get the name field working properly.

This was referenced Aug 10, 2025
Draft
Closed
@sapphi-red sapphi-red added p2-edge-case Bug, but has workaround or limited in scope (priority) feat: build labels Aug 22, 2025
@github-project-automation github-project-automation bot moved this to Discussing in Team Board Aug 22, 2025
@sapphi-red sapphi-red added this to the 7.2 milestone Aug 22, 2025
sapphi-red
sapphi-red previously approved these changes Aug 22, 2025
View reviewed changes
Copy link
Member

@sapphi-red sapphi-red left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I believe removing names from CSS entries are fine and is a fix.

@sapphi-red sapphi-red changed the title fix(build): replace 'names' with unmangled 'name' for CSS assets fix(build): replace names in the manifest with unmangled name for CSS assets Sep 19, 2025
@sapphi-red
Copy link
Member

In the last team meeting, we decided to keep names field for now for compat. I've pushed a commit for that change.

@sapphi-red sapphi-red moved this from Discussing to Approved in Team Board Sep 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bluwy bluwy bluwy approved these changes

@sapphi-red sapphi-red sapphi-red approved these changes

Assignees
No one assigned
Labels
feat: build p2-edge-case Bug, but has workaround or limited in scope (priority)
Projects
Team Board
Status: Approved
Milestone
7.2
Development

Successfully merging this pull request may close these issues.
3 participants
@CyberAP @sapphi-red @bluwy