Skip to content

Conversation

@sheremet-va
Copy link
Member

@sheremet-va sheremet-va commented Oct 22, 2025

Description

Requires: vitest-dev/vitest#8765

@sheremet-va
Copy link
Member Author

sheremet-va commented Oct 22, 2025

This test fails:

`Hello World from ${process.env.NODE_ENV}!`,

Test receives 'test' NODE_ENV, but in Vitest 3 it was "development" for some reason. I am not sure why this changed in Vite repo.

I think it might be due to the pool rewrite, the evaluation of process.env happens before the global setup now. This will be fixed in Vitest at vitest-dev/vitest#8769, but it's not crucial for Vite test suite, I think having it in the config is better for visibility.

@sapphi-red sapphi-red added the dependencies Pull requests that update a dependency file label Oct 23, 2025
@sapphi-red
Copy link
Member

It seems this log is output. It doesn't reproduce on my machine though.

(node:2764) MaxListenersExceededWarning: Possible EventEmitter memory leak detected. 11 message listeners added to [process]. MaxListeners is 10. Use emitter.setMaxListeners() to increase limit
(Use node --trace-warnings ... to show where the warning was created)

https://github.com/vitejs/vite/actions/runs/18722451249/job/53398327751?pr=20984#step:11:93

sapphi-red
sapphi-red previously approved these changes Oct 23, 2025
bluwy
bluwy previously approved these changes Oct 23, 2025
@sapphi-red sapphi-red dismissed stale reviews from bluwy and themself via cc5646e October 28, 2025 01:46
@sapphi-red sapphi-red changed the title chore(deps): update vitest chore(deps): update to vitest v4 Oct 28, 2025
@sapphi-red sapphi-red merged commit 4c2bcba into vitejs:main Oct 28, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants