Skip to content

Add autoscaling strategy Invalid conditions #1177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add autoscaling strategy Invalid conditions #1177

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 12 additions & 9 deletions pkg/controller/podautoscaler/podautoscaler_controller.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -207,9 +207,18 @@ func (r *PodAutoscalerReconciler) Reconcile(ctx context.Context, req ctrl.Reques
}

if !checkValidAutoscalingStrategy(pa.Spec.ScalingStrategy) {
// TODO: update status or conditions
// this is unrecoverable unless user make changes.
return ctrl.Result{}, nil
apimeta.SetStatusCondition(&pa.Status.Conditions, metav1.Condition{
Type: "AutoscalingStrategy",
Status: metav1.ConditionTrue,
LastTransitionTime: metav1.Now(),
Reason: "AutoscalingStrategyInvalid",
Message: fmt.Sprintf("autoscaling strategy %s is invalid", pa.Spec.ScalingStrategy),
})
return ctrl.Result{}, r.Client.Status().Update(ctx, &pa)
}

if apimeta.RemoveStatusCondition(&pa.Status.Conditions, "AutoscalingStrategy") {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we want to delete a specific AutoscalingStrategy condition here? 🤔

return ctrl.Result{}, r.Client.Status().Update(ctx, &pa)
}

switch pa.Spec.ScalingStrategy {
Expand All @@ -218,12 +227,6 @@ func (r *PodAutoscalerReconciler) Reconcile(ctx context.Context, req ctrl.Reques
case autoscalingv1alpha1.KPA, autoscalingv1alpha1.APA:
return r.reconcileCustomPA(ctx, pa)
}

newStatus := computeStatus(ctx, pa)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

any reason to remove the logic here?

if err := r.updateStatusIfNeeded(ctx, newStatus, &pa); err != nil {
return ctrl.Result{}, err
}

return ctrl.Result{}, nil
}

Expand Down