Minor speedup for infer_quantization_format when save_compressed=False

[kylesayrs]

Purpose

• Avoid calling _get_unique_quant_args in non-save compressed case, which can be expensive

Changes

• Check for not save_compressed earlier within infer_quantization_format function

[gemini-code-assist]

Summary of Changes

Hello @kylesayrs, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on a minor but impactful speedup for the infer_quantization_format function. The primary change involves restructuring the conditional logic to allow for an early exit when save_compressed is False, thereby avoiding unnecessary processing. Additionally, it cleans up an unused import and adds a new edge case check for robustness.

Highlights

• Performance Optimization: The infer_quantization_format function has been optimized to include an early exit when save_compressed is False. This change ensures that the function returns immediately without performing unnecessary computations like _get_unique_quant_args(model), which can be computationally intensive.
• Code Refinement: Removed the import and usage of is_model_quantized from quantization_format.py as its check is no longer required due to the reordered logic and early exit condition.
• Improved Edge Case Handling: Added a new early return condition within infer_quantization_format to handle cases where _get_unique_quant_args returns no weight arguments, ensuring a None is returned appropriately.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in issue comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request refactors infer_quantization_format to improve performance when save_compressed=False by avoiding an unnecessary call to _get_unique_quant_args.

[github-actions]

👋 Hi! Thank you for contributing to llm-compressor. Please add the ready label when the PR is ready for review.

Note: This is required to complete the testing suite, please only add the label once the PR is code complete and local testing has been performed.