[Feat]: enhance fault resilience via retries #421
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @ggaaooppeenngg, thanks a lot for your contribution! When you get a chance, could you rebase your branch onto the latest main? I recently fixed a bug in the pyproject.toml file that was causing the CI test failure you're seeing. |
Signed-off-by: Peng Gao <[email protected]>
ggaaooppeenngg
force-pushed
the
feat/ggaaooppeenngg/retry
branch
from
0d7ebd5 to
274393c
Compare
Signed-off-by: Peng Gao <[email protected]>
ggaaooppeenngg
force-pushed
the
feat/ggaaooppeenngg/retry
branch
from
b8a3639 to
9bcf656
Compare
|
@YuhanLiu11 Done! |
YuhanLiu11
reviewed
May 16, 2025
| ) | ||
|
|
||
| n_candidates = min(n_candidates, len(sorted_endpoints)) | ||
| return [endpoint.url for endpoint in sorted_endpoints[:n_candidates]] |
There was a problem hiding this comment.
Why do we need to make changes to the session based routing?
There was a problem hiding this comment.
The session router actually implicitly contains a side effect that if the session id mssing, it is actually a least qps first routing. And for least qps first routing, I think a retry is okay.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enhance the fault resilience via retries:
It will retry a const times among the candidate servers.
FIX #382
BEFORE SUBMITTING, PLEASE READ THE CHECKLIST BELOW AND FILL IN THE DESCRIPTION ABOVE
-swhen doinggit commit[Bugfix],[Feat], and[CI].Detailed Checklist (Click to Expand)
Thank you for your contribution to production-stack! Before submitting the pull request, please ensure the PR meets the following criteria. This helps us maintain the code quality and improve the efficiency of the review process.
PR Title and Classification
Please try to classify PRs for easy understanding of the type of changes. The PR title is prefixed appropriately to indicate the type of change. Please use one of the following:
[Bugfix]for bug fixes.[CI/Build]for build or continuous integration improvements.[Doc]for documentation fixes and improvements.[Feat]for new features in the cluster (e.g., autoscaling, disaggregated prefill, etc.).[Router]for changes to thevllm_router(e.g., routing algorithm, router observability, etc.).[Misc]for PRs that do not fit the above categories. Please use this sparingly.Note: If the PR spans more than one category, please include all relevant prefixes.
Code Quality
The PR need to meet the following code quality standards:
pre-committo format your code. SeeREADME.mdfor installation.DCO and Signed-off-by
When contributing changes to this project, you must agree to the DCO. Commits must include a
Signed-off-by:header which certifies agreement with the terms of the DCO.Using
-swithgit commitwill automatically add this header.What to Expect for the Reviews
We aim to address all PRs in a timely manner. If no one reviews your PR within 5 days, please @-mention one of YuhanLiu11
, Shaoting-Feng or ApostaC.