Skip to content

Conversation

BrianPark314
Copy link
Contributor

FILL IN THE PR DESCRIPTION HERE

FIX #xxxx (link existing issues this PR will resolve)

BEFORE SUBMITTING, PLEASE READ THE CHECKLIST BELOW AND FILL IN THE DESCRIPTION ABOVE


  • Make sure the code changes pass the pre-commit checks.
  • Sign-off your commit by using -s when doing git commit
  • Try to classify PRs for easy understanding of the type of changes, such as [Bugfix], [Feat], and [CI].
Detailed Checklist (Click to Expand)

Thank you for your contribution to production-stack! Before submitting the pull request, please ensure the PR meets the following criteria. This helps us maintain the code quality and improve the efficiency of the review process.

PR Title and Classification

Please try to classify PRs for easy understanding of the type of changes. The PR title is prefixed appropriately to indicate the type of change. Please use one of the following:

  • [Bugfix] for bug fixes.
  • [CI/Build] for build or continuous integration improvements.
  • [Doc] for documentation fixes and improvements.
  • [Feat] for new features in the cluster (e.g., autoscaling, disaggregated prefill, etc.).
  • [Router] for changes to the vllm_router (e.g., routing algorithm, router observability, etc.).
  • [Misc] for PRs that do not fit the above categories. Please use this sparingly.

Note: If the PR spans more than one category, please include all relevant prefixes.

Code Quality

The PR need to meet the following code quality standards:

  • Pass all linter checks. Please use pre-commit to format your code. See README.md for installation.
  • The code need to be well-documented to ensure future contributors can easily understand the code.
  • Please include sufficient tests to ensure the change is stay correct and robust. This includes both unit tests and integration tests.

DCO and Signed-off-by

When contributing changes to this project, you must agree to the DCO. Commits must include a Signed-off-by: header which certifies agreement with the terms of the DCO.

Using -s with git commit will automatically add this header.

What to Expect for the Reviews

We aim to address all PRs in a timely manner. If no one reviews your PR within 5 days, please @-mention one of YuhanLiu11
, Shaoting-Feng or ApostaC.

Signed-off-by: BrianPark314 <[email protected]>
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @BrianPark314, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces Horizontal Pod Autoscaler (HPA) capabilities for the router component within the Helm chart. This enhancement allows the router's replica count to automatically adjust based on CPU utilization, improving resource efficiency and ensuring the router can handle varying loads dynamically.

Highlights

  • HPA Integration: Implemented Horizontal Pod Autoscaler (HPA) support for the router deployment, enabling automatic scaling of router replicas based on CPU utilization.
  • Helm Chart Updates: Modified helm/templates/deployment-router.yaml to conditionally set the number of replicas based on whether autoscaling is enabled. A new Helm template, helm/templates/hpa-router.yaml, was added to define the HPA resource itself, which targets the router deployment.
  • Configuration Schema and Defaults: Updated helm/values.schema.json to include a new autoscaling object within routerSpec, defining parameters like enabled, minReplicas, maxReplicas, and targetCPUUtilizationPercentage. Corresponding default values for these parameters were added to helm/values.yaml.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This PR introduces HPA for the router, enabling autoscaling based on CPU utilization. It includes a new HPA template and updates to handle replica counts with autoscaling, along with additions to values.yaml and values.schema.json for configuration. Consider the suggestions to improve robustness and usability.

BrianPark314 added 3 commits July 6, 2025 12:29
Signed-off-by: BrianPark314 <[email protected]>
Signed-off-by: BrianPark314 <[email protected]>
Signed-off-by: BrianPark314 <[email protected]>
@YuhanLiu11
Copy link
Collaborator

This is a super awesome feature!! After we merge this PR, can we have a tutorial for how to use this feature?

@BrianPark314
Copy link
Contributor Author

This is a super awesome feature!! After we merge this PR, can we have a tutorial for how to use this feature?

Sure! It should be simple enough as it is right now though.

@YuhanLiu11
Copy link
Collaborator

Can you fix the conflicts? @BrianPark314 after you fix it, we can merge this PR!

@BrianPark314 BrianPark314 force-pushed the feature/router-hpa branch 2 times, most recently from fd2e863 to f6e1f5d Compare July 30, 2025 13:34
# Conflicts:
#	helm/values.yaml
@BrianPark314
Copy link
Contributor Author

@YuhanLiu11 Done!

Copy link
Collaborator

@YuhanLiu11 YuhanLiu11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@YuhanLiu11 YuhanLiu11 merged commit 9ea815d into vllm-project:main Jul 30, 2025
10 checks passed
philandstuff added a commit to poolsideai/vllm-production-stack that referenced this pull request Sep 3, 2025
Quite a few chart features have landed since the last version:
https://github.com/poolsideai/vllm-production-stack/commits/main/helm?since=2025-07-30&until=2025-09-03

I'm particularly interested in autoscaling from vllm-project#568.
philandstuff added a commit to poolsideai/vllm-production-stack that referenced this pull request Sep 3, 2025
Quite a few chart features have landed since the last version:
https://github.com/poolsideai/vllm-production-stack/commits/main/helm?since=2025-07-30&until=2025-09-03

I'm particularly interested in autoscaling from vllm-project#568.

Signed-off-by: Philip Potter <[email protected]>
@philandstuff philandstuff mentioned this pull request Sep 3, 2025
3 tasks
YuhanLiu11 pushed a commit that referenced this pull request Sep 3, 2025
Quite a few chart features have landed since the last version:
https://github.com/poolsideai/vllm-production-stack/commits/main/helm?since=2025-07-30&until=2025-09-03

I'm particularly interested in autoscaling from #568.

Signed-off-by: Philip Potter <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants