-
Notifications
You must be signed in to change notification settings - Fork 291
[Bugfix] Fix num_hidden_layers when Qwen2-Audio 7B #1803
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1803 +/- ##
==========================================
+ Coverage 73.16% 73.26% +0.09%
==========================================
Files 90 90
Lines 9929 9968 +39
==========================================
+ Hits 7265 7303 +38
- Misses 2664 2665 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Is there any e2e test to run this model? |
not yet, I will add it |
de00b2f
to
c2f2750
Compare
9c90322
to
1c5749a
Compare
@yiz-liu @MengqingCao Please taking a look? @zhangxinyuehfad Cloud you also have a test on: #1760 |
yes, it also pass on Qwen/Qwen2.5-Omni-7B |
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
cdc095b
to
16675ed
Compare
8a03a38
to
5717e41
Compare
LGTM. BTW, I had an offline discuss with @ganyi1996ppo and @yiz-liu They also think this is an accept way to resolve the problem. |
Signed-off-by: hfadzxy <[email protected]>
What this PR does / why we need it?
Fix num_hidden_layers when Qwen2-Audio 7B and #1760 :
Does this PR introduce any user-facing change?
How was this patch tested?
Closes: #1780 #1760 #1276 #359