[Misc] Cherry pick #1749 #1755 from v0.9.1-dev #1826
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Potabk
changed the title
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1826 +/- ##
==========================================
+ Coverage 71.38% 73.59% +2.20%
==========================================
Files 100 101 +1
Lines 10981 11454 +473
==========================================
+ Hits 7839 8429 +590
+ Misses 3142 3025 -117
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ApsarasX
reviewed
Jul 21, 2025
vllm_ascend/ops/fused_moe.py
Outdated
| dist.all_gather(list(chunk_hidden_states), e_hidden_states, | ||
| self.tp_group) | ||
| final_hidden_states = torch.cat(chunk_hidden_states, dim=0) | ||
| if fused_moe_state != FusedMoEState.AllGather: |
There was a problem hiding this comment.
Why did you drop the consideration of the AllGatherEP and NaiveMulticast states?
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Signed-off-by: wangli <[email protected]>
Signed-off-by: wangli <[email protected]>
Signed-off-by: wangli <[email protected]>
Signed-off-by: wangli <[email protected]>
Signed-off-by: wangli <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it?
Cherry pick #1749 #1755 from v0.9.1-dev
Co-authored-by: zouyida [email protected]
Co-authored-by: zzzzwwjj [email protected]
Co-authored-by: wangli [email protected]
Does this PR introduce any user-facing change?
How was this patch tested?