Skip to content

[BugFix] Fix a bug of running chunked-prefill with torchair. (#1378) #1844

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

MengqingCao
Copy link
Collaborator

@MengqingCao MengqingCao commented Jul 17, 2025

This PR fixes a bug of running chunked-prefill with torchair.

backport of #1378

Copy link

codecov bot commented Jul 17, 2025

Codecov Report

Attention: Patch coverage is 0% with 9 lines in your changes missing coverage. Please review.

Project coverage is 54.81%. Comparing base (f9dfde0) to head (43b6743).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
vllm_ascend/attention/mla_v1.py 0.00% 9 Missing ⚠️

❌ Your patch check has failed because the patch coverage (0.00%) is below the target coverage (100.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1844      +/-   ##
==========================================
+ Coverage   54.18%   54.81%   +0.62%     
==========================================
  Files          74       75       +1     
  Lines        9235     9326      +91     
==========================================
+ Hits         5004     5112     +108     
+ Misses       4231     4214      -17     
Flag Coverage Δ
unittests 54.81% <0.00%> (+0.62%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@MengqingCao
Copy link
Collaborator Author

The ut of mla_v1.py is WIP in #1662

…oject#1378)

  This PR fixes a bug of running chunked-prefill with torchair.

Co-authored-by: whx-sjtu <[email protected]>
Signed-off-by: whx-sjtu <[email protected]>
Signed-off-by: MengqingCao <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants