-
Notifications
You must be signed in to change notification settings - Fork 296
Qw23 t722 #1938
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: v0.9.1-dev
Are you sure you want to change the base?
Qw23 t722 #1938
Conversation
Signed-off-by: taoyuxiang <[email protected]>
Signed-off-by: taoyuxiang <[email protected]>
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
cos: Optional[torch.Tensor] = None, | ||
sin: Optional[torch.Tensor] = None, | ||
kv_cache: Optional[torch.Tensor] = None, | ||
attn_metadata: Optional[AttentionMetadata] = None) -> torch.Tensor: | ||
qkv, _ = self.qkv_proj(hidden_states) | ||
q, k, v = qkv.split([self.q_size, self.kv_size, self.kv_size], dim=-1) | ||
if type(self.rotary_emb) is RotaryEmbedding: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这里逻辑改一下,是decode走cache模式,非decode走下面的else分支
) | ||
for i in range(self.start_layer, self.end_layer): | ||
layer = self.layers[i] | ||
kv_c = kv_caches[i - self.start_layer] \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
kv_c还是改为kv_cache吧
from vllm.model_executor.layers.rotary_embedding import ( | ||
DeepseekScalingRotaryEmbedding, RotaryEmbedding) | ||
|
||
from vllm_ascend.ascend_config import get_ascend_config |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
deepseek_rope_init_func等几个接口删掉
What this PR does / why we need it?
Does this PR introduce any user-facing change?
How was this patch tested?