Skip to content

Conversation

22dimensions
Copy link
Collaborator

@22dimensions 22dimensions commented Jul 22, 2025

What this PR does / why we need it?

cherry-pick #1675 to main
This PR adds validation checking to torchair_graph_config for better reliability.

Co-authored-by: whx-sjtu [email protected]

Does this PR introduce any user-facing change?

No

How was this patch tested?

@22dimensions 22dimensions changed the title cherry-pick vllm-project#1675 #1589 #1501 #1420 #1328 from v0.9.1-dev to main [Misc] cherry-pick vllm-project#1675 #1589 #1501 #1420 #1328 from v0.9.1-dev to main Jul 22, 2025
@22dimensions 22dimensions force-pushed the pr_1675 branch 2 times, most recently from c34b02d to dd5f1d4 Compare July 23, 2025 09:30
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@22dimensions 22dimensions changed the title [Misc] cherry-pick vllm-project#1675 #1589 #1501 #1420 #1328 from v0.9.1-dev to main [Misc] cherry-pick vllm-project#1675 to main Jul 31, 2025
@22dimensions 22dimensions changed the title [Misc] cherry-pick vllm-project#1675 to main [Misc] Add extra checking to torchair_graph_config. Jul 31, 2025
Copy link

codecov bot commented Jul 31, 2025

Codecov Report

❌ Patch coverage is 97.05882% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 75.87%. Comparing base (2008152) to head (82c50d6).
⚠️ Report is 13 commits behind head on main.

Files with missing lines Patch % Lines
vllm_ascend/ascend_config.py 92.30% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1939      +/-   ##
==========================================
+ Coverage   75.05%   75.87%   +0.82%     
==========================================
  Files         103      106       +3     
  Lines       11355    11713     +358     
==========================================
+ Hits         8522     8887     +365     
+ Misses       2833     2826       -7     
Flag Coverage Δ
unittests 75.87% <97.05%> (+0.82%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@wangxiyuan wangxiyuan merged commit 8cf97d8 into vllm-project:main Aug 1, 2025
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants