-
Notifications
You must be signed in to change notification settings - Fork 449
[Bugfix] fix bug in AllgatherEP #2288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
👋 Hi! Thank you for contributing to the vLLM Ascend project. The following points will speed up your PR merge:
If CI fails, you can run linting and testing checks locally according Contributing and Testing. |
7cb7b3a
to
6ce6f3e
Compare
6ce6f3e
to
082a61e
Compare
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
082a61e
to
3a02b46
Compare
Signed-off-by: realliujiaxu <[email protected]>
3a02b46
to
b18dd81
Compare
Signed-off-by: realliujiaxu <[email protected]>
b18dd81
to
48b1b2e
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2288 +/- ##
==========================================
+ Coverage 77.37% 77.98% +0.60%
==========================================
Files 128 134 +6
Lines 16455 18500 +2045
==========================================
+ Hits 12732 14427 +1695
- Misses 3723 4073 +350
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: realliujiaxu <[email protected]>
Signed-off-by: realliujiaxu <[email protected]>
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Signed-off-by: realliujiaxu <[email protected]>
What this PR does / why we need it?
When the FusedMoEState is set to AllGatherEP, there are two bugs:
Does this PR introduce any user-facing change?
No
How was this patch tested?