Skip to content

Conversation

@22dimensions
Copy link
Collaborator

@22dimensions 22dimensions commented Oct 24, 2025

What this PR does / why we need it?

vllm requires opencv-python-headless >= 4.11.0 which requires (numpy<2.3.0,>=2), but vllm-ascend numpy version must be less than 2.0.0, so limit opencv-python-headless less than 4.11.0.86 will fix this conflict.

Does this PR introduce any user-facing change?

No

How was this patch tested?

tested by CI

@github-actions
Copy link

👋 Hi! Thank you for contributing to the vLLM Ascend project. The following points will speed up your PR merge:‌‌

  • A PR should do only one thing, smaller PRs enable faster reviews.
  • Every PR should include unit tests and end-to-end tests ‌to ensure it works and is not broken by other future PRs.
  • Write the commit message by fulfilling the PR description to help reviewer and future developers understand.

If CI fails, you can run linting and testing checks locally according Contributing and Testing.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request limits the opencv-python-headless version to resolve a numpy version conflict. The changes involve modifying the pyproject.toml and requirements.txt files to specify a maximum version for opencv-python-headless.

Copy link
Collaborator

@MengqingCao MengqingCao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this!

@MengqingCao MengqingCao added ready read for review ready-for-test start test by label for PR labels Oct 24, 2025
@MengqingCao MengqingCao merged commit afc5818 into vllm-project:main Oct 25, 2025
25 checks passed
MengqingCao pushed a commit to MengqingCao/vllm-ascend-fork that referenced this pull request Oct 25, 2025
…version conflict (vllm-project#3713)

vllm requires opencv-python-headless >= 4.11.0 which requires
(numpy<2.3.0,>=2), but vllm-ascend numpy version must be less than
2.0.0, so limit opencv-python-headless less than 4.11.0.86 will fix this
conflict.

tested by CI

- vLLM version: v0.11.0rc3
- vLLM main: https://github.com/vllm-project/vllm/commit/v0.11.0

Signed-off-by: 22dimensions <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready read for review ready-for-test start test by label for PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants