Skip to content

Conversation

@MrZ20
Copy link

@MrZ20 MrZ20 commented Oct 25, 2025

What this PR does / why we need it?

Does this PR introduce any user-facing change?

How was this patch tested?

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds a new accuracy test configuration for a model named Phi-4-mini-instruct. My review found a critical issue with the specified model name, as it does not seem to correspond to a publicly available model on the Hugging Face Hub. I've suggested a correction to what I believe is the intended model, microsoft/phi-3-mini-4k-instruct, and noted the related file changes that would be needed for consistency.

@@ -0,0 +1,14 @@
model_name: "LLM-Research/Phi-4-mini-instruct"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

The model name LLM-Research/Phi-4-mini-instruct appears to be incorrect. There are no public Phi-4 models from Microsoft at this time, and the LLM-Research organization does not seem to exist on the Hugging Face Hub. This will likely cause the test to fail when it attempts to download the model.

It's possible you intended to use microsoft/phi-3-mini-4k-instruct. If that's the case, please update the model name. For consistency, you should also consider renaming this YAML file to phi-3-mini-4k-instruct.yaml and updating its entry in tests/e2e/models/configs/accuracy.txt.

model_name: "microsoft/phi-3-mini-4k-instruct"

@github-actions
Copy link

👋 Hi! Thank you for contributing to the vLLM Ascend project. The following points will speed up your PR merge:‌‌

  • A PR should do only one thing, smaller PRs enable faster reviews.
  • Every PR should include unit tests and end-to-end tests ‌to ensure it works and is not broken by other future PRs.
  • Write the commit message by fulfilling the PR description to help reviewer and future developers understand.

If CI fails, you can run linting and testing checks locally according Contributing and Testing.

@github-actions
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

Signed-off-by: MrZ20 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant