Skip to content

Conversation

@MengqingCao
Copy link
Collaborator

@MengqingCao MengqingCao commented Oct 25, 2025

What this PR does / why we need it?

[Bugfix][Qwen3-Next] Fix Qwen3-Next with the latest maintained vllmommit id
related pr: vllm-project/vllm#26437

How was this patch tested?

CI passed with existing test.

@github-actions
Copy link

👋 Hi! Thank you for contributing to the vLLM Ascend project. The following points will speed up your PR merge:‌‌

  • A PR should do only one thing, smaller PRs enable faster reviews.
  • Every PR should include unit tests and end-to-end tests ‌to ensure it works and is not broken by other future PRs.
  • Write the commit message by fulfilling the PR description to help reviewer and future developers understand.

If CI fails, you can run linting and testing checks locally according Contributing and Testing.

@MengqingCao MengqingCao added ready read for review ready-for-test start test by label for PR labels Oct 25, 2025
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request aims to fix compatibility with a newer version of vllm for the Qwen3-Next model by introducing version-specific code paths. While the intention is correct, the implementation introduces a critical bug that will cause a NameError at runtime. Additionally, I've identified two high-severity issues related to the version checking logic that make the code brittle and difficult to maintain, increasing the risk of future bugs. My review comments provide details on these issues and suggestions for how to resolve them.

@github-actions
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@MengqingCao
Copy link
Collaborator Author

closing as done in #3428

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merge-conflicts ready read for review ready-for-test start test by label for PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant