-
Notifications
You must be signed in to change notification settings - Fork 530
[TEST]Add 2P1D multi node cases for nightly test #3764
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 4 commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
28a9e32
add prefix cache qwen3-32b-int8
jiangyunfan1 a638131
Merge remote-tracking branch 'upstream/main' into new_branch4
jiangyunfan1 153c621
Merge remote-tracking branch 'upstream/main' into new_branch4
jiangyunfan1 c61de8d
add 2P1D tests
jiangyunfan1 09081cd
consider empty tests
jiangyunfan1 1fa55f6
rm some aisbench conf
jiangyunfan1 340d0ab
add install ais bench
Potabk 713e661
fix assert error
Potabk 623f55d
fix
Potabk 6be2099
fix
Potabk 0cbd957
fix host
Potabk 27868ba
fix
Potabk 18c61bc
fix
Potabk b107b9e
fix lint
Potabk File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The
run_aisbench_casesfunction is synchronous and performs blocking I/O operations (e.g.,subprocess.Popenand reading from stdout). Calling it directly from anasyncfunction liketest_multi_nodewill block the asyncio event loop, which can lead to performance issues and defeats the purpose of usingasyncio.You should run blocking functions in a separate thread to avoid blocking the event loop. You can use
asyncio.to_threadfor this.Note: You'll need to add
import asyncioat the top of the file.