[WIP] support sliding window of decoding flash attn#161
Open
mayuyuace wants to merge 1 commit intovllm-project:mainfrom
Open
[WIP] support sliding window of decoding flash attn#161mayuyuace wants to merge 1 commit intovllm-project:mainfrom
mayuyuace wants to merge 1 commit intovllm-project:mainfrom
Conversation
Signed-off-by: mayuyuace <qiming1.zhang@intel.com>
Collaborator
|
do you want to relax the check in https://github.com/jikunshang/vllm-xpu-kernels/blob/a78e7334ff02871c67f2a21084065518fa7bc704/csrc/flash_attn/flash_api.cpp#L108? |
Collaborator
Author
Not related with this PR. |
Collaborator
|
Hi @mayuyuace , please delete the is_local judgement in https://github.com/vllm-project/vllm-xpu-kernels/blob/main/csrc/flash_attn/flash_api.cpp#L108 to make the kernel run into decode kernel. |
mayuyuace
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enable sliding window of decoding flash attention, and add UT for this param.