Open
Conversation
Signed-off-by: Zhang, Wuxun <wuxun.zhang@intel.com>
Signed-off-by: Zhang, Wuxun <wuxun.zhang@intel.com>
Signed-off-by: Zhang, Wuxun <wuxun.zhang@intel.com>
Contributor
There was a problem hiding this comment.
Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
jikunshang
reviewed
Mar 12, 2026
tests/test_topk_per_row.py
Outdated
| import torch | ||
|
|
||
| from tests.register_ops import topk_per_row_prefill, topk_per_row_decode | ||
| from vllm.platforms import current_platform |
Collaborator
There was a problem hiding this comment.
should not import any vllm code in this repo.
jikunshang
reviewed
Mar 12, 2026
tests/test_topk_per_row.py
Outdated
| Compare results from CUDA top_k_per_row with torch.topk. | ||
| Both results should be sorted and contain the same top-k elements. | ||
| """ | ||
| num_rows = cuda_indices.shape[0] |
Signed-off-by: yangqun <qun.yang@intel.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.PLEASE FILL IN THE PR DESCRIPTION HERE ENSURING ALL CHECKLIST ITEMS ABOVE HAVE BEEN CONSIDERED.
Purpose
Add Sycl top_k_per_row kernel for prefill and decode
Copilot adapted most codes from https://github.com/vllm-project/vllm/blob/main/csrc/sampler.cu except subgroup-level prefix sum algorithm since CUDA uses CUB library.
Test Plan
python -m pytest tests/test_topk_per_row.py -v
Test Result
pass
(Optional) Documentation Update
BEFORE SUBMITTING, PLEASE READ https://docs.vllm.ai/en/latest/contributing (anything written below this line will be removed by GitHub Actions)