[CI] Unifying Dockerfiles for ARM and X86 Builds #21343

kebe7jun · 2025-07-22T01:08:30Z

Essential Elements of an Effective PR Description Checklist

The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
The test plan, such as providing test command.
The test results, such as pasting the results comparison before and after, or e2e results
(Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model.

Purpose

Unify the way CPUs are built to reduce unnecessary maintenance costs.

Test Plan

See CI.

Test Result

https://github.com/vllm-project/vllm/actions/runs/16434542371/job/46442029158?pr=21343

(Optional) Documentation Update

gemini-code-assist

Code Review

This pull request unifies the Dockerfiles for ARM and x86 CPU builds. However, the current method of setting the LD_PRELOAD environment variable dynamically based on the architecture is unreliable. The review suggests using an entrypoint script to ensure the variable is correctly set at runtime.

docker/Dockerfile.cpu

github-actions · 2025-07-22T01:46:53Z

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

hmellor · 2025-07-22T17:52:08Z

.github/workflows/lint-and-deploy.yaml

+    runs-on: ${{ matrix.os }}
+    strategy:
+      matrix:
+        os: [ubuntu-latest, ubuntu-24.04-arm]


This workflow is just for checking the Helm charts, is it necessary to run it on multiple hardwares?

This test is not just a deployment test of helm, but actually tests the most basic reasoning ability. Or do you mean that we should build some real arm tests? Or do you mean that there is no need for arm tests?
We currently lack arm cpu tests, and it is a good idea to use Github's actions arm runner to do basic smoke testing.

@hmellor Any feedback? Should I remove it?

Perhaps you can run this only on Arm platform as a basic smoke testing.

Sorry, I don't quite understand. Do you mean to keep only ubuntu-24.04-arm?

Right, to save the time :)

Thanks, updated. BTW, these two are actually executed concurrently.

bigPYJ1151

LGTM, just some nits. Please take a look.

Please also update the note on top of the Dockerfile.cpu and add note for build argument --platform.

bigPYJ1151 · 2025-07-25T08:07:51Z

.github/workflows/lint-and-deploy.yaml

+    runs-on: ${{ matrix.os }}
+    strategy:
+      matrix:
+        os: [ubuntu-latest, ubuntu-24.04-arm]


Perhaps you can run this only on Arm platform as a basic smoke testing.

docker/Dockerfile.cpu

Signed-off-by: Kebe <[email protected]>

bigPYJ1151

Thanks for the refactor :)

Hope @hmellor 's concern also is resolved. Let's see whether related tests can pass.

hmellor · 2025-07-25T14:49:12Z

Yeah my concern is resolved. I was just pointing out that that GitHub actions workflow is just for testing Helm charts work properly and that the images built in the workflow are not kept/uploaded anywhere, so it wasn't worth doing both.

hmellor · 2025-07-30T07:29:49Z

Since switching to the arm GitHub actions runners, the lint-and-deploy workflow has been taking almost 3x longer and is causing long queues in our GitHub Actions jobs

kebe7jun · 2025-07-30T07:33:23Z

Since switching to the arm GitHub actions runners, the lint-and-deploy workflow has been taking almost 3x longer and is causing long queues in our GitHub Actions jobs

Then I'll submit a PR to switch back. I didn't notice the time cost of this Pipeline before.

hmellor · 2025-07-30T07:35:58Z

No problem, we weren't to know it'd be that much slower. Please cc me in your PR :)

Signed-off-by: Kebe <[email protected]>

Signed-off-by: Kebe <[email protected]> Signed-off-by: shuw <[email protected]>

Signed-off-by: Kebe <[email protected]> Signed-off-by: x22x22 <[email protected]>

Signed-off-by: Kebe <[email protected]>

Signed-off-by: Kebe <[email protected]> Signed-off-by: Jinzhen Lin <[email protected]>

Signed-off-by: Kebe <[email protected]> Signed-off-by: Paul Pak <[email protected]>

Signed-off-by: Kebe <[email protected]>

Signed-off-by: Kebe <[email protected]> Signed-off-by: Boyuan Feng <[email protected]>

Signed-off-by: Kebe <[email protected]> Signed-off-by: Diego-Castan <[email protected]>

Signed-off-by: Kebe <[email protected]>

mergify bot added documentation Improvements or additions to documentation ci/build labels Jul 22, 2025

gemini-code-assist bot reviewed Jul 22, 2025

View reviewed changes

docker/Dockerfile.cpu Outdated Show resolved Hide resolved

docker/Dockerfile.cpu Show resolved Hide resolved

kebe7jun force-pushed the fix/unify-cpu-dockerfile branch 5 times, most recently from f685564 to 73dc19b Compare July 22, 2025 04:19

kebe7jun marked this pull request as ready for review July 22, 2025 04:42

kebe7jun requested a review from hmellor as a code owner July 22, 2025 04:42

hmellor reviewed Jul 22, 2025

View reviewed changes

bigPYJ1151 reviewed Jul 25, 2025

View reviewed changes

kebe7jun force-pushed the fix/unify-cpu-dockerfile branch 2 times, most recently from c27f79b to 51bf7c4 Compare July 25, 2025 09:21

[CI] Unifying Dockerfiles for ARM and X86 Builds

8728c90

Signed-off-by: Kebe <[email protected]>

kebe7jun force-pushed the fix/unify-cpu-dockerfile branch from 51bf7c4 to 8728c90 Compare July 25, 2025 09:22

bigPYJ1151 approved these changes Jul 25, 2025

View reviewed changes

bigPYJ1151 added the ready ONLY add when PR is ready to merge/full CI is needed label Jul 25, 2025

bigPYJ1151 enabled auto-merge (squash) July 25, 2025 12:48

simon-mo disabled auto-merge July 25, 2025 14:33

simon-mo merged commit 396ee94 into vllm-project:main Jul 25, 2025
45 of 47 checks passed

kebe7jun deleted the fix/unify-cpu-dockerfile branch July 25, 2025 14:35

bigPYJ1151 mentioned this pull request Jul 28, 2025

[Bugfix] Fix environment variable setting in CPU Dockerfile #21730

Merged

4 tasks

kebe7jun mentioned this pull request Jul 30, 2025

[CI] rollback lint-and-deploy pipeline using amd machine #21912

Merged

liuyumoye pushed a commit to liuyumoye/vllm that referenced this pull request Jul 31, 2025

[CI] Unifying Dockerfiles for ARM and X86 Builds (vllm-project#21343)

35f71ad

Signed-off-by: Kebe <[email protected]>

skmkt mentioned this pull request Aug 4, 2025

[Bug]: downgrade the wrong platform of pytorch version, should be ppc instead aarch64 #22183

Open

1 task

wenscarl pushed a commit to wenscarl/vllm that referenced this pull request Aug 4, 2025

[CI] Unifying Dockerfiles for ARM and X86 Builds (vllm-project#21343)

117a4c3

Signed-off-by: Kebe <[email protected]> Signed-off-by: shuw <[email protected]>

x22x22 pushed a commit to x22x22/vllm that referenced this pull request Aug 5, 2025

[CI] Unifying Dockerfiles for ARM and X86 Builds (vllm-project#21343)

94d9349

Signed-off-by: Kebe <[email protected]> Signed-off-by: x22x22 <[email protected]>

Pradyun92 pushed a commit to Pradyun92/vllm that referenced this pull request Aug 6, 2025

[CI] Unifying Dockerfiles for ARM and X86 Builds (vllm-project#21343)

9804070

Signed-off-by: Kebe <[email protected]>

npanpaliya pushed a commit to odh-on-pz/vllm-upstream that referenced this pull request Aug 6, 2025

[CI] Unifying Dockerfiles for ARM and X86 Builds (vllm-project#21343)

5a0a05d

Signed-off-by: Kebe <[email protected]>

jinzhen-lin pushed a commit to jinzhen-lin/vllm that referenced this pull request Aug 9, 2025

[CI] Unifying Dockerfiles for ARM and X86 Builds (vllm-project#21343)

36dc6a0

Signed-off-by: Kebe <[email protected]> Signed-off-by: Jinzhen Lin <[email protected]>

paulpak58 pushed a commit to paulpak58/vllm that referenced this pull request Aug 13, 2025

[CI] Unifying Dockerfiles for ARM and X86 Builds (vllm-project#21343)

b96de07

Signed-off-by: Kebe <[email protected]> Signed-off-by: Paul Pak <[email protected]>

taneem-ibrahim pushed a commit to taneem-ibrahim/vllm that referenced this pull request Aug 14, 2025

[CI] Unifying Dockerfiles for ARM and X86 Builds (vllm-project#21343)

e20ecd5

Signed-off-by: Kebe <[email protected]>

BoyuanFeng pushed a commit to BoyuanFeng/vllm that referenced this pull request Aug 14, 2025

[CI] Unifying Dockerfiles for ARM and X86 Builds (vllm-project#21343)

d19eab8

Signed-off-by: Kebe <[email protected]> Signed-off-by: Boyuan Feng <[email protected]>

diegocastanibm pushed a commit to diegocastanibm/vllm that referenced this pull request Aug 15, 2025

[CI] Unifying Dockerfiles for ARM and X86 Builds (vllm-project#21343)

54a92e5

Signed-off-by: Kebe <[email protected]> Signed-off-by: Diego-Castan <[email protected]>

epwalsh pushed a commit to epwalsh/vllm that referenced this pull request Aug 28, 2025

[CI] Unifying Dockerfiles for ARM and X86 Builds (vllm-project#21343)

87d6fff

Signed-off-by: Kebe <[email protected]>

googlercolin pushed a commit to googlercolin/vllm that referenced this pull request Aug 29, 2025

[CI] Unifying Dockerfiles for ARM and X86 Builds (vllm-project#21343)

b421d07

Signed-off-by: Kebe <[email protected]>

Uh oh!

[CI] Unifying Dockerfiles for ARM and X86 Builds #21343

[CI] Unifying Dockerfiles for ARM and X86 Builds #21343

Uh oh!

Conversation

kebe7jun commented Jul 22, 2025 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Essential Elements of an Effective PR Description Checklist

Purpose

Test Plan

Test Result

(Optional) Documentation Update

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Jul 22, 2025

Uh oh!

hmellor Jul 22, 2025

Choose a reason for hiding this comment

Uh oh!

kebe7jun Jul 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

kebe7jun Jul 25, 2025

Choose a reason for hiding this comment

Uh oh!

bigPYJ1151 Jul 25, 2025

Choose a reason for hiding this comment

Uh oh!

kebe7jun Jul 25, 2025

Choose a reason for hiding this comment

Uh oh!

bigPYJ1151 Jul 25, 2025

Choose a reason for hiding this comment

Uh oh!

kebe7jun Jul 25, 2025

Choose a reason for hiding this comment

Uh oh!

bigPYJ1151 left a comment

Choose a reason for hiding this comment

Uh oh!

bigPYJ1151 Jul 25, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

bigPYJ1151 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

hmellor commented Jul 25, 2025

Uh oh!

hmellor commented Jul 30, 2025

Uh oh!

kebe7jun commented Jul 30, 2025

Uh oh!

hmellor commented Jul 30, 2025

Uh oh!

Uh oh!

kebe7jun commented Jul 22, 2025 •

edited by github-actions bot

Loading

kebe7jun Jul 23, 2025 •

edited

Loading